Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prototype "cm init" to check some system deps (git, wget) and pull cm4mlops repo #1279

Closed
gfursin opened this issue Aug 8, 2024 · 7 comments
Assignees

Comments

@gfursin
Copy link
Contributor

gfursin commented Aug 8, 2024

No description provided.

@gfursin
Copy link
Contributor Author

gfursin commented Sep 16, 2024

I implemented this functionality. @arjunsuresh and @anandhu-eng - can you please check that it works on your side? We can then discuss how to update the docs to keep the installation clean ... Thanks!

@arjunsuresh
Copy link
Contributor

Hi @gfursin I added cm init to this github action. It works fine on Ubuntu but fails on Windows. Is this expected?

@gfursin
Copy link
Contributor Author

gfursin commented Sep 17, 2024

Hmm, thank you for noting - let me check.

@gfursin
Copy link
Contributor Author

gfursin commented Sep 17, 2024

Oh, yes, I see the problem. We should not check wget.exe in "cm init" on Windows since it is added/used via cm scripts ... At this moment "cm init" fails on Windows because wget is not available ;) ...

@gfursin
Copy link
Contributor Author

gfursin commented Oct 2, 2024

I have tested cm init in various projects - it seems to be working fine and I can capture and process installation errors via CM interface.

@arjunsuresh - may I ask you to update the docs at https://docs.mlcommons.org/inference/install/#__tabbed_1_1 to use pip install cmind && cm init as default, please?

In the future, we may be extending cm init with other repositories that are not necessarily related to cm4mlops ...

Thanks a lot!

@arjunsuresh
Copy link
Contributor

Hi @gfursin For MLPerf run support especially for new users the current cm4mlops package is working really well and so far we have had no issues raised regarding this. We also have the cm init option as an alternative for those doing development work. I don't think we should change the default setting and invite more support queries.

Also, can you please add MLCommons to the cmind pypi package owner list? Initially we had to create cm4mlops package when we were not able to do a critical cmind release when you were offline.

@gfursin
Copy link
Contributor Author

gfursin commented Nov 10, 2024

Sure, let's keep two methods - I have MLPerf users that prefer original installation to have a control over which CM repositories they initialize and use - they can now choose whatever is better for them.

@gfursin gfursin closed this as completed Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants