Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting inputs implementing the LogDensityProblems interface #115

Closed
sethaxen opened this issue Jan 5, 2023 · 0 comments · Fixed by #122
Closed

Supporting inputs implementing the LogDensityProblems interface #115

sethaxen opened this issue Jan 5, 2023 · 0 comments · Fixed by #122

Comments

@sethaxen
Copy link
Member

sethaxen commented Jan 5, 2023

Both DynamicHMC and now also AdvancedHMC (TuringLang/AdvancedHMC.jl#301) support as inputs objects that implement the LogDensityProblems interface. It makes sense then to support as inputs objects that implement the LogDensityProblems interface. We might even consider switching to using LogDensityProblems internally.

I don't think we should switch to using LogDensityProblems internally, mainly because currently the LogDensityProblems API only supports computing the log density and its gradient, while we want to also support optimizers that compute the Hessian.

Turing is starting to use LogDensityProblems under the hood, but to keep support for Hessians, we should probably continue to use its OptimizationFunction.

It might be worth pushing to have Hessian abilities in the LogDensityProblems API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant