You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've noticed that almost all end-of-semester final projects, where students typically use just one model, greatly benefit from { runtime: 'mediapipe' }. I wonder if we should reconsider making this the default, paired with clear documentation and instructions for switching to other runtimes when using multiple models. (see #69#134)
Additionally, there's #225, which could be worth exploring further in this context.
@ziyuan-linn, is there anything I might be overlooking here?
The text was updated successfully, but these errors were encountered:
I think mediapipe runtime's memory leak issue is still the main concern. If we do switch over, we would want clear documentation that any long-running projects (in a gallery or show setting for example) should use the tfjs runtime. I am happy to take a look again and investigate whether mediapipe's memory leak has been addressed not.
Additionally, this would be a breaking change. For some models, the options are different depending on which runtime is selected.
Ah right, I forgot about the memory leak! Let's continue to leave tf.js as the default then and revisit if/when that is resolved! Can you elaborate on how this is "breaking", I'm having trouble imagining a scenario where that would apply.
Ah I looked through the source code and it would be as big of a problem as I thought. The "breaking" probably only applies to one case: when loading a offline model, a tfjs models require detectorModelUrl and landmarkModelUrl in the options object, but mediapipe models require solutionPath instead.
I've noticed that almost all end-of-semester final projects, where students typically use just one model, greatly benefit from
{ runtime: 'mediapipe' }
. I wonder if we should reconsider making this the default, paired with clear documentation and instructions for switching to other runtimes when using multiple models. (see #69 #134)Additionally, there's #225, which could be worth exploring further in this context.
@ziyuan-linn, is there anything I might be overlooking here?
The text was updated successfully, but these errors were encountered: