Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a build-able example (perhaps in a separate repo) that can be used as an unit test in CI #16

Open
thedeadliestcatch opened this issue Apr 17, 2024 · 1 comment

Comments

@thedeadliestcatch
Copy link

Based off the issues everyone seems to be experiencing using this as a component, I think the ideal scenario would be to provide an example repo that settles on one approach to successfully build any of the examples.

This will also allow a proper CI stage chain to verify against esp-idf as versions get released.

@thedeadliestcatch thedeadliestcatch changed the title Provided a build-able example (perhaps in a separate repo) that can be used as an unit test in CI Provide a build-able example (perhaps in a separate repo) that can be used as an unit test in CI Apr 17, 2024
@thedeadliestcatch
Copy link
Author

I have tested #10, #9 and #5. None of the suggested solutions or references will work.

For example, the "hack" involving the full copy of the library into a component with a new CMake configuration will not result in the correct linker references.

The hello world example is also broken. The examples at least in this tree are correct (ex. bus.i2c union, other code refers to .sda directly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant