Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

200 line limit in read_bibliography() #44

Open
wilkox opened this issue Oct 31, 2023 · 0 comments
Open

200 line limit in read_bibliography() #44

wilkox opened this issue Oct 31, 2023 · 0 comments

Comments

@wilkox
Copy link

wilkox commented Oct 31, 2023

I was getting an error when running read_bibliography() on a RIS file downloaded from EMBASE:

Error in detect_delimiter(zsub) : 
  import failed: unknown reference delimiter

It turned out that only the first 200 lines of the reference were being read, which caused detect_delimiter() to subsequently fail to detect that the reference ended with an ER line and was therefore "endrow" delimited. Replacing lines 93-94 of read_bibliography.R with:

zsub <- z[seq_len(length(z))]

fixed the problem.

Is there a reason for the 200-line limit? Otherwise would you accept a pull request with the change I made?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wilkox