Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grocerycrud dropdowns think elements == 0 are unselected #64

Open
bowserm opened this issue Jun 2, 2012 · 4 comments
Open

Grocerycrud dropdowns think elements == 0 are unselected #64

bowserm opened this issue Jun 2, 2012 · 4 comments

Comments

@bowserm
Copy link
Collaborator

bowserm commented Jun 2, 2012

This sucks. If an item in a Grocerycrud dropdown has a value of zero, Grocerycrud gets confused and thinks that nothing in the dropdown is selected.

It shouldn't be hard to fix, but we will have to modify the grocery crud library.

If you get it to work, document any changes you make to the Grocerycrud source code because any update of Grocerycrud will wipe it out.

@fieldju
Copy link
Contributor

fieldju commented Jun 13, 2012

@bowserm
Copy link
Collaborator Author

bowserm commented Jun 14, 2012

This is an easy problem to fix i think. I'll look at it later.

On Wed, Jun 13, 2012 at 4:29 PM, Justin Field
[email protected]
wrote:

http://www.grocerycrud.com/forums/topic/536-set-relation-drop-down-issue/


Reply to this email directly or view it on GitHub:
https://github.com/fieldju/CMS/issues/64#issuecomment-6316708

@fieldju
Copy link
Contributor

fieldju commented Jun 14, 2012

DO NOT MODIFY GROCERY CRUD,
I talked to the main dev on the grocery crud project who had this to say
"It is really rare to use 0 as a primary key and it is not a good SQL technique because you will probably have some problems in the future with the default 0 value or the 0 id value."

He suggested to not use 0 as an id rather bump everything up one, however I am not working on anything I am just trying to add some comments on issues so the next team has an idea whats going on

@bowserm
Copy link
Collaborator Author

bowserm commented Jun 14, 2012

He's probably right. Good thinking, sir

On Wed, Jun 13, 2012 at 7:32 PM, Justin Field
[email protected]
wrote:

DO NOT MODIFY GROCERY CRUD,
I talked to the main dev on the grocery crud project who had this to say
"It is really rare to use 0 as a primary key and it is not a good SQL technique because you will probably have some problems in the future with the default 0 value or the 0 id value."

He suggested to not use 0 as an id rather bump everything up one, however I am not working on anything I am just trying to add some comments on issues so the next team has an idea whats going on


Reply to this email directly or view it on GitHub:
https://github.com/fieldju/CMS/issues/64#issuecomment-6319070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants