Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update symfony/string requirement from ^6.0 to ^7.1 #301

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 19, 2024

Updates the requirements on symfony/string to permit the latest version.

Release notes

Sourced from symfony/string's releases.

v7.1.1

Changelog (symfony/string@v7.1.0...v7.1.1)

Changelog

Sourced from symfony/string's changelog.

CHANGELOG

7.1

  • Add localeLower(), localeUpper(), localeTitle() methods to AbstractUnicodeString

6.2

  • Add support for emoji in AsciiSlugger

5.4

  • Add trimSuffix() and trimPrefix() methods

5.3

  • Made AsciiSlugger fallback to parent locale's symbolsMap

5.2.0

  • added a FrenchInflector class

5.1.0

  • added the AbstractString::reverse() method
  • made AbstractString::width() follow POSIX.1-2001
  • added LazyString which provides memoizing stringable objects
  • The component is not marked as @experimental anymore
  • added the s() helper method to get either an UnicodeString or ByteString instance, depending of the input string UTF-8 compliancy
  • added $cut parameter to Symfony\Component\String\AbstractString::truncate()
  • added AbstractString::containsAny()
  • allow passing a string of custom characters to ByteString::fromRandom()

5.0.0

  • added the component as experimental
Commits
  • 60bc311 Merge branch '7.0' into 7.1
  • fbabbf6 Merge branch '6.4' into 7.0
  • 0475303 Merge branch '5.4' into 6.4
  • dd2c915 [String] Fix Inflector for 'hardware'
  • 8beaf4e Merge branch '7.0' into 7.1
  • 5a6ef5c Merge branch '6.4' into 7.0
  • a147c0f Merge branch '5.4' into 6.4
  • 1428772 Revert "minor #54653 Auto-close PRs on subtree-splits (nicolas-grekas)"
  • 6f41b18 Merge branch '7.0' into 7.1
  • 4ed8062 Merge branch '6.4' into 7.0
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [symfony/string](https://github.com/symfony/string) to permit the latest version.
- [Release notes](https://github.com/symfony/string/releases)
- [Changelog](https://github.com/symfony/string/blob/7.1/CHANGELOG.md)
- [Commits](symfony/string@v6.0.0...v7.1.1)

---
updated-dependencies:
- dependency-name: symfony/string
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Jun 19, 2024
Copy link

codeclimate bot commented Jun 19, 2024

Code Climate has analyzed commit a4b68dd and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Collaborator

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose we set the (production) Symfony requirements to ^5.4 || ^6.4 || ^7.0 to allow installations with all supported major Symfony versions, and add corresponding blocklist entries in the Dependabot configuration. @mjaschen What do you think?

@mjaschen
Copy link
Owner

Hi @oliverklee

sounds good. Do you have experience with configuring Dependabot in that way?

After skimming the docs, I came up with this config entries, but don't know if that's the right way to do it:

version: 2

updates:

  - package-ecosystem: composer
    directory: "/"
    schedule:
      interval: weekly
      day: wednesday
      time: "09:00"
      timezone: "Europe/Berlin"
    open-pull-requests-limit: 10
    target-branch: main
    allow:
      - dependency-name: "symfony/finder"
        versions:
          - "^5.4"
          - "^6.4"
          - "^7.0"
      - dependency-name: "symfony/http-foundation"
        versions:
          - "^5.4"
          - "^6.4"
          - "^7.0"
      - [...]

oliverklee added a commit that referenced this pull request Jun 27, 2024
…ions

As this project is a library, it should be installable with as many
Symfony versions that still are supported in order to make it
usable across as many projects as possible.

So reinstate compatibility with Symfony 5.4, and add compatibility with
Symfony 7.0 and 7.1.

At the moment, Symfony 5.4, 6.4, 7.0 and 7.1 are still supported
by the Symfony project:

https://symfony.com/releases

Closes #301
oliverklee added a commit that referenced this pull request Jun 27, 2024
As this project is a library, it should be installable with as many
Symfony versions that still are supported in order to make it
usable across as many projects as possible.

So reinstate compatibility with Symfony 5.4, and add compatibility with
Symfony 7.0 and 7.1.

At the moment, Symfony 5.4, 6.4, 7.0 and 7.1 are still supported
by the Symfony project:

https://symfony.com/releases

Closes #301
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 27, 2024

Looks like symfony/string is no longer being updated by Dependabot, so this is no longer needed.

@dependabot dependabot bot closed this Jun 27, 2024
@dependabot dependabot bot deleted the dependabot/composer/main/symfony/string-tw-7.1 branch June 27, 2024 12:20
mjaschen pushed a commit that referenced this pull request Jun 27, 2024
As this project is a library, it should be installable with as many
Symfony versions that still are supported in order to make it
usable across as many projects as possible.

So reinstate compatibility with Symfony 5.4, and add compatibility with
Symfony 7.0 and 7.1.

At the moment, Symfony 5.4, 6.4, 7.0 and 7.1 are still supported
by the Symfony project:

https://symfony.com/releases

Closes #301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants