Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with hipchat/hubot-hipchat #2

Open
bartekn opened this issue Feb 6, 2013 · 7 comments
Open

Not working with hipchat/hubot-hipchat #2

bartekn opened this issue Feb 6, 2013 · 7 comments

Comments

@bartekn
Copy link

bartekn commented Feb 6, 2013

Seems not to be working with https://github.com/hipchat/hubot-hipchat.

Bartek Nowotarski:
@bot @bartek is a member of test
Robot Robot:
Ok, bartek is a member of test.
Bartek Nowotarski:
@bot standup for test
Robot Robot:
@BartekNowotarski your turn
Ok, let's start the standup: Bartek Nowotarski
Bartek Nowotarski:
@bot next
Robot Robot:
@bartek but it's not your turn! Use skip [someone] or next [someone] instead.

I've found information that robot.usersForFuzzyName moved to robot.brain.usersForFuzzyName but changing it does not help.

@miyagawa
Copy link
Owner

miyagawa commented Feb 6, 2013

We use the plugin with hipchat actually and it seems to be working. That said, hipchat nickname resolution has been changing a lot lately, and it is a pain in the ass to deal with, especially when you change the nickname (XMPP binding doesn't get the update).

Try 'BartekNowotarski is a member of test' instead?

@bartekn
Copy link
Author

bartekn commented Feb 6, 2013

Unfortunatelly, it's not helping:

Bartek Nowotarski:
@bot BartekNowotarski is a member of test
Robot Robot:
I don't know anything about BartekNowotarski.
Bartek Nowotarski:
@bot @BartekNowotarski is a member of test
Robot Robot:
I don't know anything about BartekNowotarski.

@miyagawa
Copy link
Owner

miyagawa commented Feb 6, 2013

try with a space between first and last? If it doesn't help, clear the hubot's redis database to start over. This kind of name unmatch has happened a couple of times for me too and it required manual resolution. This is ultimately a problem with hubot-hipchat binding, since my code doesn't deal with that at all :/

@bartekn
Copy link
Author

bartekn commented Feb 6, 2013

I changed message when bot receives 'next' command and it seems that msg.message.user.id is undefined:

Bartek Nowotarski
@bot Bartek Nowotarski is a member of test
Robot Robot
Ok, Bartek Nowotarski is a member of test.
Bartek Nowotarski
@bot standup for test
Robot Robot
Ok, let's start the standup: Bartek Nowotarski
@BartekNowotarski your turn
Bartek Nowotarski
test
@bot next
Robot Robot
@bartek but it's not your turn (it's 207981 and you are undefined)! Use skip [someone] or next [someone] instead.

@miyagawa
Copy link
Owner

miyagawa commented Feb 6, 2013

Guess it's related to the issue I reported a while ago for hubot-hipchat:
hipchat/hubot-hipchat#34

If I remember correctly, It happens when you change your nickname after you let the hubot bot sign in to the network. the solution is to manually munge the redis data or clear it to start over :/

@bartekn
Copy link
Author

bartekn commented Feb 6, 2013

Hmm, the case is I didn't changed my nickname since I can remember and I started playing with hubot-standup yesterday ;).

@miyagawa
Copy link
Owner

miyagawa commented Feb 6, 2013

well, try dumping the redis storage and messing with the msg.message object then - clearly your msg.message.user.id being undefined indicates something is wrong :)

The workaround, if you don't have time to mess with possible hubot-hipchat bugs, is to use the skip command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants