Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Quickstart #237

Open
kathmath opened this issue Jun 8, 2023 · 2 comments
Open

JS Quickstart #237

kathmath opened this issue Jun 8, 2023 · 2 comments

Comments

@kathmath
Copy link
Contributor

kathmath commented Jun 8, 2023

In the web quickstart for tracking your first event we tell people to init, identify, then track. Including identify isn't necessary to track an event and doesn't make sense in the case of anon activity and could cause confusion on id mgmt - I think it should be removed or clarified it's not req'd unless the user is identified. Other guides for mobile just have init + track.

@ranic
Copy link
Contributor

ranic commented Jun 9, 2023

Challenge is that if you want to track a "Signup" event, it is required (because that's non-anonymous).

Maybe we can add a comment above .identify() that says something like "// Remove this if the user is anonymous" or something?

@kathmath
Copy link
Contributor Author

totally fair. as i'm thinking more about it this might be a broader thing to consider. we're using signup in most of the quickstart guides except http (but in mobile we don't include identify) for consistency i'm assuming. but then in the ref docs we're all over the place with event naming and the JS ref example isn't an authentication event. maybe in quickstart guides we can show sending both an anon event and auth event. I'd challenge using signup across the board in these - ofc you can track business critical events like signup, purchase, etc client side but it's a bit at odds with our usual recommendation to track these server-side for safety.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants