Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceAccount replication doesn't preserve annotations #286

Open
vivek1612 opened this issue Jul 3, 2023 · 1 comment · May be fixed by #313
Open

ServiceAccount replication doesn't preserve annotations #286

vivek1612 opened this issue Jul 3, 2023 · 1 comment · May be fixed by #313
Labels

Comments

@vivek1612
Copy link

Describe the bug

Replicated service accounts only have replicator.v1.mittwald.de/replicated-at and replicator.v1.mittwald.de/replicated-from-version. Annotations in the source service account are missing in the target.

To Reproduce

Create a service account and a namespace. Notice the service account will be replicated to the new namespace but the replicated service account will not have testAnnotation.

apiVersion: v1
kind: ServiceAccount
metadata:
  name: test-sa
  namespace: default
  annotations:
    replicator.v1.mittwald.de/replicate-to-matching: app=my-app
    testAnnotation: testAnnotation
apiVersion: v1
kind: Namespace
metadata:
  name: test-ns
  labels:
    app: my-app

Expected behavior

The target service account should have all the annotations that were present in the source, besides the ones that trigger replication.

Environment:

  • Kubernetes version: 1.27 (EKS)
  • kubernetes-replicator version: 2.9.1
@vivek1612 vivek1612 added the bug label Jul 3, 2023
@fiksn fiksn linked a pull request Nov 14, 2023 that will close this issue
@pschichtel
Copy link

#189 describes the same problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants