-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nodes: Introduce custom shader nodes for Mitsuba BSDFs #31
base: master
Are you sure you want to change the base?
Conversation
3978972
to
fb59713
Compare
0ce52c6
to
3da61eb
Compare
b92d99f
to
7edc090
Compare
Hi, |
Hello, Thank you for the comment. This could be a nice complementary feature to this PR. Could you maybe open a new PR with your example factored as a Blender shader node (built on top of what is implemented in this PR). You probably need to wait until this PR is merged first though :) Cheers! |
@ros-dorian Is there a plan to merge this? |
It will be a super useful feature ! |
Hi @nebnes, Thanks for your interest. The only reason this PR is not merged is because of some memory corruptions inside Blender which is caused by the custom node editor. It seems to also be an issue with other add-ons that have the same functionality. I did not try to see if the problem still occurs with more recent Blender versions (or if this code is still compatible altogether). I will spend a bit of time updating the PR and do some testing and I will report my findings here. Cheers! |
Hi @ros-dorian, |
Although Mitsuba BSDFs can be approximated using Blender shader nodes during import, the conversion is not flawless and leads to inconsistencies when exporting.
Therefore, we introduce custom shader nodes that perfectly match Mitsuba's BSDFs and textures. This has the great advantages to allow for a perfect import/export loop and finer control over the look of each material.
This feature is enabled by first selecting the
Mitsuba
rendering engine and then clicking on Use Mitsuba Material Nodes in the material sidebar while in the shading tab.The node editor then provides access to the wide library of BSDFs available in Mitsuba in the same fashion as Blender's Cycles.