Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-stack repositories #13

Open
remi opened this issue Mar 20, 2019 · 0 comments
Open

Support multi-stack repositories #13

remi opened this issue Mar 20, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@remi
Copy link
Member

remi commented Mar 20, 2019

Currently, we configure the stacks used for pull requests created in a repository with a comma-separated list of stacks:

https://my-dispatch-app.com/webhooks?stacks=elixir,graphql

For repositories containing multiple applications however, it would be great to specify stacks for each root subdirectory:

https://my-dispatch-app.com/webhooks?stacks[api]=elixir,graphql&stacks[webapp]=webapp

If a pull request is created, we could look at the list of impacted files and extract stacks based on root subdirectories included in the list. So for example if the list of impacted files is:

  • api/mix.exs
  • api/lib/foo/bar.ex

The stacks used to fetch experts/learners for the pull request would be elixir and graphql.

The rest of the process would stay the same — for example contributors for the whole repository would be considered, not “contributors in the api subdirectory”.

@remi remi added the enhancement New feature or request label Mar 20, 2019
@garno garno added rfc Request for comments on new features and removed rfc Request for comments on new features labels Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants