Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irmin-pack: integrity_check minimal indexing stores #2133

Open
icristescu opened this issue Nov 7, 2022 · 0 comments
Open

irmin-pack: integrity_check minimal indexing stores #2133

icristescu opened this issue Nov 7, 2022 · 0 comments

Comments

@icristescu
Copy link
Contributor

When importing a snapshot with the current code, there is an implicit integrity check: the objects are added to store bottom up, their hash are computed and the resulting hash is compared with the expected hash written in the snapshot file.

If we switch to the approach in #2125 , the import will consists in opening a store and there is no implicit integrity check anymore. We should add an option to do the integrity check when opening a store or add a separate integrity check function in the API, so that users can call it explicitly.

Note that an integrity check function currently exists, but it uses the index to traverse the pack file. This is not enough for stores with minimal indexing strategy (which is the case of the stores using the gc-based snapshots).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant