Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from icon fonts to SVG sprites #153

Open
toastal opened this issue Oct 15, 2024 · 0 comments
Open

Move from icon fonts to SVG sprites #153

toastal opened this issue Oct 15, 2024 · 0 comments
Labels
Site Changes to the website

Comments

@toastal
Copy link

toastal commented Oct 15, 2024

SVG sprites using <symbol> are more flexible & semantic. Fonts behave oddly & are a old-school hack from a decade ago to support Internet Explorer. Font Awesome provides SVG sprites https://docs.fontawesome.com/web/add-icons/svg-sprites. Additionally this would be a good time to added accessibility

<a class="navbar-item" href="https://www.minetest.net" title="Minetest">
	<svg>
		<use xlink:href="/your-path-to-fontawesome/sprites/solid.svg#home"></use>
		<desc>Minetest</desc>
	</svg>
</a>

(& so forth) as right now all icons in the bar have no accessible text (where <desc> provides such text). You can take a peek using a terminal browser such as w3m

$ nix-shell -p w3m --run "w3m https://blog.minetest.net"

Minetest Blog
About
     

Minetest Blog

Minetest's official blog - see what's new in Minetest!
                                                                                                             
Post image                                                                                                          

13 Oct 2024

Introducing Our New Name

“Is this a Minecraft clone? Is it like Minecraft Alpha?” If you’ve been a member of our community for some time,
you are probably aware of how often these questions remind us of what people think of when they hear the name
“Minetest”: a rip-off of a similar genre-defining game. Truth be told, that was celeron55’s initial plan. But
things change, and Minetest evolved. Now, the time has come for Minetest to assume a new identity and prove it has
moved beyond its original purpose.

Read more

& the auxiliary banner navigation is missing. Additionally this “Post image” is the incorrect usage of alt text.

1

Footnotes

  1. Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute.

@GreenXenith GreenXenith added the Site Changes to the website label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site Changes to the website
Projects
None yet
Development

No branches or pull requests

2 participants