Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes... #19

Open
jussipo opened this issue Dec 26, 2018 · 0 comments
Open

Some fixes... #19

jussipo opened this issue Dec 26, 2018 · 0 comments

Comments

@jussipo
Copy link

jussipo commented Dec 26, 2018

I think that to
func valid_frame_received should add fix:
case ACK:
...
if(num_acked <= num_in_window && self->transport_fifo.n_frames) { // There is one frame at least
...

Also to func min_poll one fix:
...
else {
// Sender cannot send new frames so resend old ones (if there's anyone there)
if((window_size > 0) && remote_connected && self->transport_fifo.n_frames) { //There is at least one frame

Better to be safe than sorry...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant