show.html.erb #77 ダウンロードリンク追加 #84
Conversation
Walkthrough変更は、 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant View
participant Archive
User->>View: アーカイブの表示をリクエスト
View->>Archive: アーカイブの詳細を取得
Archive-->>View: 動画を含むアーカイブデータを返す
View-->>User: ダウンロードリンク付きのアーカイブを表示
User->>View: ダウンロードリンクをクリック
View->>User: 動画のダウンロードを開始
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
app/views/archives/show.html.erb
Outdated
| @@ -18,6 +18,9 @@ | |||
| <div>追加日: <%= @archive.created_at.in_time_zone('Tokyo').strftime('%Y-%m-%d %H:%M') %></div> | |||
| <div>状態: <%= @archive.status %></div> | |||
| </div> | |||
| <div> | |||
| <%= link_to("ダウンロード", @archive.video, download: @archive.title ) %> | |||
There was a problem hiding this comment.
Consider sanitizing the filename for download.
The archive title is used directly as the download filename, which could cause issues if it contains invalid characters.
Consider sanitizing the filename:
-<%= link_to("ダウンロード", @archive.video, download: @archive.title ) %>
+<%= link_to("ダウンロード", @archive.video, download: sanitize_filename(@archive.title)) %>You'll need to implement a helper method like:
def sanitize_filename(filename)
filename.strip.gsub(/[^0-9A-Za-z.\-]/, '_')
end
app/views/archives/show.html.erb
Outdated
| <div> | ||
| <%= link_to("ダウンロード", @archive.video, download: @archive.title ) %> | ||
| </div> |
There was a problem hiding this comment.
Add a video presence check to prevent 404 errors.
The download link should only be displayed when a video is attached, similar to how the video player is conditionally rendered.
Consider wrapping the download link in a conditional check:
- <div>
- <%= link_to("ダウンロード", @archive.video, download: @archive.title ) %>
- </div>
+ <% if @archive.video.attached? %>
+ <div>
+ <%= link_to("ダウンロード", @archive.video, download: @archive.title ) %>
+ </div>
+ <% end %>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <div> | |
| <%= link_to("ダウンロード", @archive.video, download: @archive.title ) %> | |
| </div> | |
| <% if @archive.video.attached? %> | |
| <div> | |
| <%= link_to("ダウンロード", @archive.video, download: @archive.title ) %> | |
| </div> | |
| <% end %> |
💡 Codebase verification
Authorization check required for video downloads
The codebase currently lacks any authentication or authorization mechanisms:
- No authentication checks in ApplicationController
- No authorization checks in ArchivesController for the show action
- Direct video access through ActiveStorage without access control
This confirms the original review comment's concern about implementing proper authorization. The video downloads are currently accessible to anyone who has the URL.
Key locations requiring attention:
app/controllers/application_controller.rb: Add authentication mechanismapp/controllers/archives_controller.rb: Add authorization check inshowactionapp/views/archives/show.html.erb: Video download link should only be visible to authorized users
🔗 Analysis chain
Verify download authorization.
Ensure that only authorized users can download videos. Consider adding authorization checks.
Let's check if there are any existing authorization checks in the codebase:
Consider implementing authorization using one of these approaches:
- Add a before_action in ArchivesController
- Use a policy framework like Pundit
- Implement download tracking for security monitoring
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Look for authorization-related code
echo "Checking for authorization mechanisms..."
rg -l "before_action|authenticate|authorize|current_user" app/controllers/
rg -l "cancan|pundit|devise" Gemfile
Length of output: 245
Script:
#!/bin/bash
# Let's check the content of archives_controller.rb to see the authorization mechanisms
echo "Checking ArchivesController content..."
cat app/controllers/archives_controller.rb
# Let's also check for any application-wide authentication in application_controller
echo -e "\nChecking ApplicationController content..."
cat app/controllers/application_controller.rb
Length of output: 2239
|
@coderabbitai summary |
✅ Actions performedSummary regeneration triggered. |
|
@tomya-n 動いたらスクリーンショットおねがいします |
|
動作例 |
|
|
|
テスト落ちた。 |
これで動画が問題なくダウンロード出来ていればできるはず！
Summary by CodeRabbit