Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for groupby search #672

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Add test cases for groupby search #672

merged 1 commit into from
Mar 18, 2024

Conversation

ThreadDao
Copy link
Contributor

@ThreadDao ThreadDao commented Mar 12, 2024 •
edited
Loading

  • add test cases for groupby search
  • update case: different metrics type for BinFlat and BinIvfFlat index
  • update case: create scalar index for all kinds of supported FieldType
  • update case: json support multiple forms
  • add case: change of vector's legal dim
  • add case: search from growing segments

see also: #670

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Mar 12, 2024
@mergify mergify bot added ci-passed auto merge needed label test/ci intergration test labels Mar 13, 2024
@congqixia congqixia mentioned this pull request Mar 18, 2024
Closed
congqixia
congqixia approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Mar 18, 2024
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, ThreadDao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Mar 18, 2024
@sre-ci-robot sre-ci-robot merged commit aa29152 into milvus-io:master Mar 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@sunby sunby Awaiting requested review from sunby

@yah01 yah01 Awaiting requested review from yah01

Assignees

@congqixia congqixia

Labels
approved review approved ci-passed auto merge needed label lgtm look good to me size/XL Denotes a PR that changes 500-999 lines. test/ci intergration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThreadDao @sre-ci-robot @congqixia