Build using CMake #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks very good! Thank you for the contribution! I'm not the biggest fan of introducing additional build dependencies but as it looks like a build system is required, CMake would have been my choice, too. I looked at the changes and everything looks good, so I'll test them out this evening and get back to you. |
This ensures that the paths in the scripts/udev rule always correspond to where the binary was actually installed
|
Any update on this? |
This fixes suspend behaviour on Ubuntu Fixes milgner#16
|
Ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to build with different compilers and also ensures that the binary path is correct in all the scripts.