Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function prototypes don't match functions #65

Open
smangham opened this issue Jul 15, 2024 · 1 comment
Open

Function prototypes don't match functions #65

smangham opened this issue Jul 15, 2024 · 1 comment

Comments

@smangham
Copy link

Small issue: A 'naive' clone and compile of ks_spectrum on desktop Ubuntu fails, as w_open_ks_eigen is prototyped as includes/io_ks_eigen.h:133 as:

ks_eigen_file *w_open_ks_eigen(int flag, char *filename, int parity);

But defined in generic_ks/io_helpers_ks_eigen.c:82 as:

static ks_eigen_file *w_open_ks_eigen(int flag, char *filename, int parity) {
  ; ...
}

Looking around, it seems that this was allowed by gcc 3, but gcc 4 is stricter. I appreciate that this is almost certainly going to be compiled with older/stable HPC specialised compiler versions, so presumably they aren't complaining about this yet. Is it likely that a fix would have knock-on effects? If not, I'm happy to open a pull request to fix the various instances of it.

@detar
Copy link
Contributor

detar commented Nov 18, 2024

This was fixed in a later version of the develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants