Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: enable automated building #13

Open
maddyscientist opened this issue Jul 14, 2017 · 4 comments
Open

Feature request: enable automated building #13

maddyscientist opened this issue Jul 14, 2017 · 4 comments

Comments

@maddyscientist
Copy link
Contributor

At present the MILC build system requires manual copying and editing of the Makefile to set building options, e.g., whether to build with QUDA of QPhiX support. This prevents automated testing of MILC.

While using cmake or even autotools would be the most user friendly, and most desired from our perspective, I note that simply extending the current Makefile to support environment variables for setting paths would give the rudimentary support we would like.

E.g., from the current Makefile, there is:

WANTQUDA    = true
WANT_CL_BCG_GPU = false                                                                                                                                                                                                                                                                                                                                                   
WANT_FN_CG_GPU = true
WANT_FL_GPU = true
WANT_FF_GPU = true
WANT_GF_GPU = true

If this was simply changed to

WANTQUDA    ?= true
WANT_CL_BCG_GPU ?= false                                                                                                                                                                                                                                                                                                                                                   
WANT_FN_CG_GPU ?= true
WANT_FL_GPU ?= true
WANT_FF_GPU ?= true
WANT_GF_GPU ?= true

then the user could set these variables with environment variables, overriding the contents of the Makefile. This could easily be extended to the QIO, QMP, and other options as needed.

Background: we (@mathiaswagner and I) would like to enable QUDA's pull request system to fetch the latest develop version of MILC, build QUDA-enabled MILC and run MILC's internal rhmc and rhmd tests for each pull request for QUDA. This will prevent any regressions in MILC compatibility as QUDA continues to rapidly evolve and will prevent wasted cycles going forward.

Thoughts?

@stevengottlieb
Copy link
Collaborator

stevengottlieb commented Jul 14, 2017 via email

@detar
Copy link
Contributor

detar commented Jul 14, 2017 via email

@mathiaswagner
Copy link
Contributor

Thanks Carleton. That will make scripting the MILC build a lot easier.

@detar
Copy link
Contributor

detar commented Oct 4, 2017 via email

detar pushed a commit that referenced this issue Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants