Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precondition dependencies for "stroke" #4

Open
plstcharles opened this issue Jul 9, 2020 · 0 comments
Open

Precondition dependencies for "stroke" #4

plstcharles opened this issue Jul 9, 2020 · 0 comments
Assignees
Labels
invalid This doesn't seem right question Further information is requested

Comments

@plstcharles
Copy link
Member

Originally: issue #130 on COVI-Canada. Opened by @carriepl on 2020/07/03.

Currently, in _get_preexisting_conditions(), there is the following bit of code :

        if c_name == 'stroke':
            modifier = len(conditions)

So, someone currently can't have a stroke if they don't have one of the previous preconditions (smoker, diabetes, heart_disease, cander, COPD, asthma) but they can as soon as they get any of them, even just something like "smoker".

It is definitely wrong but I don't know what the expected behavior is so I can't really fix it at the moment.

If the expected behavior is that those preconditions simply increase the likelihood of having a stroke but they are not requirements for having a stroke, then I guess something like on the order : modifier = len(conditions) + 1 would resolve the issue with minimal change.

If some of those conditions (like "heart disease") are indeed requirements for having a stroke and the other pre-conditions simply increase the likelihood, then the code should be modified to reflect that dependency. For instance something like modifier = int("heart_disease" in conditions) * len(conditions) or something to that general effect.

@plstcharles plstcharles added invalid This doesn't seem right question Further information is requested labels Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants