Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0 length activities caused by mobility_planner._add_to_the_schedule() #101

Open
3 tasks done
aubreymcleod opened this issue Mar 9, 2022 · 0 comments
Open
3 tasks done

Comments

@aubreymcleod
Copy link

Prerequisites

Please answer the following questions for yourself before submitting an issue.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Expected Behavior

add_to_the_schedule function constrains the end_time for tentative activities; if an activity's end_time would naturally fall during the closed_hours for its assigned location the activity has its end_time adjusted to the closed_hours. This function theoretically also restricts activities with a duration of zero from being added to the schedule.

Current Behavior

In the edge case where the activity starts at the closed_hour, the end_time will also be set to the closed_hour, and the activity will be added to the schedule. This in effect creates an activity with a duration of zero which is undesirable.

Failure Information

After inspecting add_to_the_schedule, it appears that this bug is caused by a missing '=' on line 1075 of the 'mobility_planner'. Where the start time is checked against the close time; currently '>', when probably should be '>='.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant