add workflow

.github/workflows/main.yaml

@@ -0,0 +1,73 @@
+name: "testing"
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+
+jobs:
+    qa:
+        name: Quality assurance
+        runs-on: ubuntu-latest
+
+        steps:
+            - name: Checkout
+              uses: actions/checkout@v4
+
+            - name: Validate composer.json and composer.lock
+              run: composer validate
+
+            - name: Cache Composer packages
+              id: composer-cache
+              uses: actions/cache@v3
+              with:
+                path: vendor
+                key: ${{ runner.os }}-php-${{ hashFiles('**/composer.lock') }}
+                restore-keys: |
+                  ${{ runner.os }}-php-
+
+            - name: Install dependencies
+              if: steps.composer-cache.outputs.cache-hit != 'true'
+              run: composer install --prefer-dist --no-progress
+
+            - name: Coding Standard
+              run: composer run-script phpstan
+
+    tests:
+        name: Tests
+        runs-on: ubuntu-latest
+
+        strategy:
+            matrix:
+              php:
+                - 8.1
+                - 8.2
+                - 8.3
+              composer-args: [ "" ]
+            fail-fast: false
+
+        steps:
+            - name: Checkout
+              uses: actions/checkout@v4
+
+            - name: Install PHP
+              uses: shivammathur/setup-php@v2
+              with:
+                  php-version: ${{ matrix.php }}
+
+            - name: Cache PHP dependencies
+              uses: actions/cache@v3
+              with:
+                  path: vendor
+                  key: ${{ runner.os }}-php-${{ matrix.php }}-composer-${{ hashFiles('**/composer.json') }}
+                  restore-keys: ${{ runner.os }}-php-${{ matrix.php }}-composer-
+
+            - name: Install dependencies
+              run: composer install --prefer-dist --no-progress ${{ matrix.composer-args }}
+
+            - name: Tests
+              run: composer test
+
+            - name: Tests coverage
+              run: composer coverage

composer.json

@@ -34,5 +34,11 @@
         "psr-4": {
             "MichehTest\\Cache\\": "test/"
         }
+    },
+    "scripts": {
+        "phpstan": "vendor/bin/phpstan analyse",
+        "test": "vendor/bin/phpunit",
+        "coverage": "vendor/bin/phpunit --coverage-text",
+        "coverage-html": "vendor/bin/phpunit --coverage-html=coverage"
     }
 }

phpstan-baseline.neon

@@ -0,0 +1,16 @@
+parameters:
+	ignoreErrors:
+		-
+			message: "#^Unreachable statement \\- code above always terminates\\.$#"
+			count: 1
+			path: src/CacheUtil.php
+
+		-
+			message: "#^Result of \\|\\| is always false\\.$#"
+			count: 1
+			path: src/Header/CacheControl.php
+
+		-
+			message: "#^Unsafe usage of new static\\(\\)\\.$#"
+			count: 1
+			path: src/Header/CacheControl.php

phpstan.neon.dist

@@ -2,7 +2,7 @@ includes:
     #- phpstan-baseline.neon
 
 parameters:
-    level: 5
+    level: 6
     paths:
         - src/
         #- test/

src/CacheUtil.php

@@ -434,6 +434,7 @@ protected function getTimestampFromValue($time)
             return strtotime($time);
         }
 
+        /** @phpstan-ignore-next-line */
         throw new InvalidArgumentException('Could not create timestamp from ' . gettype($time) . '.');
     }
 

src/Header/CacheControl.php

@@ -43,6 +43,7 @@ abstract class CacheControl
      */
     protected static function createFromString($string)
     {
+        /** @phpstan-ignore-next-line */
         $cacheControl = new static();
 
         $parts = explode(',', $string);
@@ -158,6 +159,7 @@ public function hasNoTransform()
      */
     public function withExtension($name, $value)
     {
+        /** @phpstan-ignore-next-line */
         if (!is_string($name) || !is_string($value)) {
             throw new InvalidArgumentException('Name and value of the extension have to be a string.');
         }

test/CacheUtilTest.php

@@ -161,6 +161,7 @@ public function testWithRelativeExpiresAndString()
             //'InvalidArgumentException',
             'Expected an integer with the number of seconds, received string.'
         );
+        /** @phpstan-ignore-next-line */
         $this->cacheUtil->withRelativeExpires($response, 'now');
     }
 
@@ -307,7 +308,7 @@ public function testHasCurrentStateWithModified($ifUnmodified, $lastModified, $i
         $request->method('getHeaderLine')->willReturnMap($map);
 
 
-        $result = $this->cacheUtil->hasCurrentState($request, null, $lastModified);
+        $result = $this->cacheUtil->hasCurrentState($request, '', $lastModified);
         $this->assertSame($isCurrent, $result);
     }
 

test/Header/CacheControlTest.php

@@ -179,7 +179,7 @@ public function testFromStringWithUnknownDirectiveFlag()
     public function testWithMaxAge()
     {
         $control = $this->getControlWithDirective('max-age', 5);
-        $this->assertReturn($control->withMaxAge('5'));
+        $this->assertReturn($control->withMaxAge(5));
     }
 
     /**
@@ -263,6 +263,7 @@ public function testWithExtensionInvalidType()
             //'InvalidArgumentException',
             'Name and value of the extension have to be a string.'
         );
+        /** @phpstan-ignore-next-line */
         $this->cacheControl->withExtension('foo', true);
     }
 

test/Header/CacheControlTestCase.php

@@ -9,6 +9,8 @@
 namespace MichehTest\Cache\Header;
 
 use Micheh\Cache\Header\CacheControl;
+use Micheh\Cache\Header\RequestCacheControl;
+use Micheh\Cache\Header\ResponseCacheControl;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
@@ -30,7 +32,7 @@ protected function setUp(): void
     }
 
     /**
-     * @param string $value
+     * @param string|int|bool|null $value
      */
     protected function assertReturn($value)
     {
@@ -39,7 +41,7 @@ protected function assertReturn($value)
 
     /**
      * @param array<string, mixed> $directives
-     * @param MockObject|CacheControl
+     * @param MockObject|CacheControl $control
      */
     protected function assertSameDirectives($directives, $control)
     {
@@ -54,8 +56,8 @@ protected function assertSameDirectives($directives, $control)
 
     /**
      * @param string $name
-     * @param string|int $value
-     * @return MockObject|CacheControl
+     * @param string|int|bool|null $value
+     * @return MockObject|CacheControl|RequestCacheControl|ResponseCacheControl
      */
     protected function getControlWithDirective($name, $value)
     {
@@ -68,7 +70,7 @@ protected function getControlWithDirective($name, $value)
 
     /**
      * @param string $name
-     * @return MockObject|CacheControl
+     * @return MockObject|CacheControl|RequestCacheControl|ResponseCacheControl
      */
     protected function getControlWithGetDirective($name)
     {
@@ -81,7 +83,7 @@ protected function getControlWithGetDirective($name)
 
     /**
      * @param string $name
-     * @return MockObject|CacheControl
+     * @return MockObject|CacheControl|RequestCacheControl|ResponseCacheControl
      */
     protected function getControlWithHasFlag($name)
     {