Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does HNSW search sometimes match NO_MORE_DOCS? #297

Open
vigyasharma opened this issue Sep 12, 2024 · 1 comment
Open

Does HNSW search sometimes match NO_MORE_DOCS? #297

vigyasharma opened this issue Sep 12, 2024 · 1 comment

Comments

@vigyasharma
Copy link
Contributor

We have a check to separately handle NO_MORE_DOCS while parsing the results from an HNSW approximate search. We should not be returning NO_MORE_DOCS in the first place. Creating an issue to investigate when and why this happens.

https://github.com/mikemccand/luceneutil/blob/main/src/main/knn/KnnGraphTester.java#L619-L624
@vigyasharma vigyasharma mentioned this issue Sep 12, 2024
Merged
@mikemccand
Copy link
Owner

I'm hoping this was a holdover from some long ago fixed bug? I'll try simply removing that check and see if anything bad happens...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikemccand @vigyasharma