Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test performance impact of addDocuments vs addDocument #252

Open
mikemccand opened this issue Dec 14, 2023 · 1 comment
Open

Test performance impact of addDocuments vs addDocument #252

mikemccand opened this issue Dec 14, 2023 · 1 comment

Comments

@mikemccand
Copy link
Owner

[Spinoff from https://github.com/apache/lucene/pull/12829#issuecomment-1855755782]

I'm curious what overhead we pay calling addDocument for N documents, versus indexing all N docs in a single addDocuments call. IW has non-trivial entry / exit costs (checking out / locking the DWPT, checking flush triggers, locking to free the DWPT, etc.).

One simple way to test this would be to modify our existing Indexer.java when reading from a binary line file docs to index each block with a single addDocuments call.

@jpountz
Copy link
Collaborator

jpountz commented Dec 14, 2023

We could use IndexGeonames, which has a batchAddDocuments boolean value aimed at checking exactly this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants