This repository has been archived by the owner on Dec 1, 2024. It is now read-only.
fix that default pkg's method count is at most 1 #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description: No matter how many default package methods there are, the printed result is always 1 for default package methods count. Explanation: The name in line 49 may be "", which means corresponding method is from default package. For the default package methods, code runs into else branch since no child has name "". Therefore, for every default package method, a new Node is created in line 53. For non-first default package method, the newly created Node will always replace the former Node in line 59, and get its count equals 1 in line 63. Overall, method count of default package is always at most 1. I added an else if branch, which avoids making new Node if we already has a Node when the coming method is a default package method.