-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for additional test libraries #7
Comments
@microsoftly Any ideas on how to implement this ? For example, we are using I was thinking of being able to pass the function to do the expectation but I'm not sure if that can work. |
@bilby91 all expectations are done in ExpectedMesage.ts. We also know the expectations that are going to be run (just based off the current ones). All we need to do is encapsulate the current expectation calls in some other class or function that picks the correct framework. This part is rather clear. The less clear part is how to register which framework to use. |
Good. I like the idea. So, we are going to support different frameworks in a static way then. We will need to push code in order to support new frameworks right? What do you think about a global property that defines de framework? |
Good. I will implement this in the next days. Will add jest as the second test framework :) |
Hi, Any chance you can look at Ava's assertion library? Whilst currently it's possible to use Ava and rely on Chai by telling Ava to not fail in the absence of it's own assertions it means we get huge Chai stack traces and means we can't use test planning. |
@benswinburne It shouldn't be hard to add it. I think that beside of obviously adding the AvaExpectation class we need to remove the hard dependencies plus make conditional importing. Something that we had in the past and then was removed (I think). |
@bilby91 @benswinburne I've extended the library to be able to toggle between assertion libraries based on config or options. It's currently on the dev branch. I've opened up a new ticket specifically for the ava task. I can take it on, though I'd be happy to accept work from either of you or reviews of what I submit. |
Can you point into the commit that does the change @microsoftly ? |
@benswinburne @bilby91 ava support added, see #60 (it's a bit of a hack, but it allows users to run with ava) |
If you want support added for a library that we don't already support, please comment below. We will also happily accept PRs.
Once a new test library is accepted, I will open up a new issue to track it
The text was updated successfully, but these errors were encountered: