Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syntax highlighting is white and incorrect for html #64699

Closed
joshunger opened this issue Dec 9, 2018 · 5 comments
Closed

syntax highlighting is white and incorrect for html #64699

joshunger opened this issue Dec 9, 2018 · 5 comments
Assignees
@octref @alexr00

Comments

@joshunger
Copy link
Contributor

joshunger commented Dec 9, 2018 •
edited
Loading

Issue Type: Bug

Syntax highlighting is white and incorrect for html

image

Minimal example:

<!DOCTYPE html>
<html lang="en">
  <head>
    <title>foo</title>
  </head>
  <body>
    <div></div>
    <script src="http://dummy"></script
    ><script src="http://dummy"></script
    ><!--[if lte IE 9]><script src="http://dummy"></script><![endif]-->
  </body>
</html>

An extension formatted it but it appears the syntax highlighting is a code bug?

VS Code version: Code - Insiders 1.30.0-insider (85f805a, 2018-12-05T12:13:44.894Z)
OS version: Darwin x64 18.2.0

System Info
Item Value
CPUs Intel(R) Core(TM) i5-7267U CPU @ 3.10GHz (4 x 3100)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 3
Memory (System) 16.00GB (0.14GB free)
Process Argv .
Screen Reader no
VM 0%
Extensions (18)
Extension Author (truncated) Version
vscode-eslint dba 1.7.0
xml Dot 2.3.2
EditorConfig Edi 0.12.5
prettier-vscode esb 1.7.2
flow-for-vscode flo 0.8.5
python ms- 2018.11.0
vscode-jest Ort 2.9.2
vscode-docker Pet 0.4.0
java red 0.35.0
sass-indented rob 1.4.9
vscode-fileutils sle 2.13.3
code-spell-checker str 1.6.10
sort-lines Tyr 1.7.0
vscode-java-debug vsc 0.15.0
vscode-java-dependency vsc 0.2.0
vscode-java-pack vsc 0.5.0
vscode-java-test vsc 0.11.1
vscode-maven vsc 0.11.3
@vscodebot vscodebot bot added the insiders label Dec 9, 2018
@alexr00
Copy link
Member

alexr00 commented Dec 10, 2018

The html grammar we use doesn't handle the greater than symbol being on the next line like this:

</script
><script src="http://dummy"></script
><!--[if lte IE 9]><script src="http://dummy"></script><![endif]-->

Is this something that you expect to be ok? It isn't a standard way of formatting html as far as I know.

@joshunger
Copy link
Contributor Author

I was wondering that too.

It seems to validate at https://validator.w3.org/.

Is this the correct spec? See https://www.w3.org/TR/html5/syntax.html#end-tags

End tags must have the following format:

  1. The first character of an end tag must be a U+003C LESS-THAN SIGN character (<).
  2. The second character of an end tag must be a U+002F SOLIDUS character (/).
  3. The next few characters of an end tag must be the element’s tag name.
  4. After the tag name, there may be one or more space characters.
  5. Finally, end tags must be closed by a U+003E GREATER-THAN SIGN character (>).

And https://www.w3.org/TR/html5/infrastructure.html#space-characters says -

The space characters, for the purposes of this specification, are U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR).

🤔

What does Code use for html syntax?

@alexr00
Copy link
Member

alexr00 commented Dec 10, 2018

The html formatter is here, but I don't know all the details. The html grammar we use for syntax highlighting is here: https://github.com/textmate/html.tmbundle.

You mentioned that you're using an extension to provide formatting: the build in VS Code html formatting fixed those strange end tags for me. Based on the spec you linked they're allowed, they just aren't what I expected to see.

Since the issue is with the grammar, I can forward this issue to https://github.com/textmate/html.tmbundle.

@alexr00 alexr00 mentioned this issue Dec 10, 2018
Open
@alexr00
Copy link
Member

alexr00 commented Dec 10, 2018

This issue was moved to textmate/html.tmbundle#97

@alexr00 alexr00 closed this as completed Dec 10, 2018
@joshunger
Copy link
Contributor Author

Thanks @alexr00

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshunger @octref @alexr00