syntax highlighting is lost after call to handlebars helper with string parameter inside script block

[Jusys]

• VSCode Version: 1.17.0 (issue present in both 32bit and 64bit)
• OS Version: Windows 7 32bit, Windows 10 64bit

Steps to Reproduce:

1. Create handlebars file;
2. Type some html code;
3. Create script block with function;
4. Inside function make a call to handlebars helper with string parameter;
5. After this syntax highlighting will be lost;

If call to helper is without string parameter, everything is ok:

Reproduces without extensions: I have no extensions installed

[aeschli]

The problem is that the handlebar grammar uses the 'source.js' grammar for embedded code. That's not really correct due to the templates. The grammar that we use in VSCode doesn't handle the {{{ helper 'param'}}} and gets stuck in a rule (FYI @sheetalkamat) . It's a weakness of TextMate that it doesn't have a proper embedding story and a problem in the embedded code can ruin the colouring of the rest of the file
IMO the right approach is for the handlebars grammar to not include source.js, but have included simple highlighting rules for embedded code, e.g. do keyword, comment and strings highlighting.

[aeschli]

This issue was moved to daaain/Handlebars#99

[Jusys]

aeschli: Thank you for clarification