Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css] @namespace is not syntax highlighted #1659

Closed
dstorey opened this issue Dec 26, 2015 · 3 comments
Closed

[css] @namespace is not syntax highlighted #1659

dstorey opened this issue Dec 26, 2015 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@dstorey
Copy link
Member

dstorey commented Dec 26, 2015

Works correctly in the parser for linting and in Intellisense, but isn't syntax highlighted as missing from css.plist

screen shot 2015-12-26 at 2 37 41 am

Syntax should be:

namespace
: NAMESPACE_SYM S* [namespace_prefix S_]? [STRING|URI] S_ ';' S*
;
namespace_prefix
: IDENT
;

My knowledge of the syntax of css.plist and regexp isn't good enough at the moment to work out how to add the optional IDENT, as there is no predefined ident like there is for strings, etc. I know how to highlight the @namespace and string component though.

I figure the IDENT should be coloured the same as @namespace as that is how the media type token is coloured for '@media media-type'

@dstorey
Copy link
Member Author

dstorey commented Dec 26, 2015

IDENT is also needed for @Keyframes, so would be good to add it in a way that can be reused, rather than defining it twice.

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Dec 28, 2015
@bpasero bpasero added this to the Backlog milestone Dec 28, 2015
@aeschli aeschli added the css-less-scss Issues and items concerning CSS,Less,SCSS styling label Jan 8, 2016
@aeschli
Copy link
Contributor

aeschli commented Jan 8, 2016

This issue was moved to textmate/css.tmbundle#24

@aeschli aeschli closed this as completed Jan 8, 2016
@aeschli aeschli reopened this Jan 8, 2016
@aeschli aeschli added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jan 8, 2016
@aeschli
Copy link
Contributor

aeschli commented Feb 22, 2017

This got fixed in the meantime.

@aeschli aeschli closed this as completed Feb 22, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants