Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quotation marks in script type causing syntax issues #162542

Closed
daniel4ing opened this issue Oct 3, 2022 · 4 comments
Closed

Quotation marks in script type causing syntax issues #162542

daniel4ing opened this issue Oct 3, 2022 · 4 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug php PHP support issues
Milestone
Backlog

Comments

@daniel4ing
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.71.2/1.72
  • OS Version: Windows 11

Steps to Reproduce:

  1. If the script tag contains a type, the syntax highlighter stops working with the PHP tags inside the script tag.
  2. If I remove the script type, it works again.
    ezgif-4-a4628634f4
@aeschli
Copy link
Contributor

aeschli commented Oct 3, 2022

What is the language mode the editor is in? PHP or HTML?

@aeschli aeschli added the info-needed Issue requires more information from poster label Oct 3, 2022
@daniel4ing
Copy link
Author

daniel4ing commented Oct 3, 2022 •
edited
Loading

ezgif-2-6343b6dfa5
Language mode is set to PHP, the version I'm currently using is 7.4 and the file is also a PHP file.

Actually, the moment I add application/ld+json, it just stops working.

@aeschli aeschli assigned roblourens and unassigned aeschli Oct 4, 2022
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug php PHP support issues and removed info-needed Issue requires more information from poster labels Oct 4, 2022
@roblourens roblourens added this to the Backlog milestone Oct 4, 2022
@roblourens
Copy link
Member

Our grammar is pulled from https://github.com/atom/language-php, which is no longer maintained. There are several open issues around embedded languages, similar to this. I am going to start closing PHP grammar issues against this issue, which tracks replacing our grammar #162707

@KapitanOczywisty
Copy link
Contributor

This is HTML issue, which is also not maintained and duplicate of #36280

@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug php PHP support issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@roblourens @aeschli @KapitanOczywisty @daniel4ing @vscodenpa