Fix spinning wheel in boot apps view #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eskibear
approved these changes
Mar 28, 2024
| @@ -153,7 +153,7 @@ export class MemoryViewProvider implements vscode.WebviewViewProvider { | |||
| case "FetchData": { | |||
| const type = message.type; | |||
| if (processKey === '') { | |||
| processKey = this.storeLiveProcesses.values().next().value.liveProcess.processKey; | |||
| processKey = this.storeLiveProcesses.values().next().value.liveProcess?.processKey; | |||
| } | |||
| if (type !== '' && type === "Heap Memory" && processKey !== undefined && processKey !== '') { | |||
There was a problem hiding this comment.
type !== '' && type === "Heap Memory"
type !== '' is obviously unnecessary. A lot of chaos in conditional checks, we might fix that in a separate PR, gracefully checking whether type of processkey is null or empty. @testforstephen
|
Likely custom debug event with PID and debug session started event were coming in reverse order in the past, i.e. debug session started first and then custom debug event with PID... |
testforstephen
approved these changes
Apr 2, 2024
|
@BoykoAlex thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to match custom debug event against project name in
BootAppandDebugSession.The fix in memory provider is just to avoid errors in the console
Fixes #216