Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Testing Result Display #1659

Open
Ao-Last opened this issue Feb 1, 2024 · 5 comments
Open

Wrong Testing Result Display #1659

Ao-Last opened this issue Feb 1, 2024 · 5 comments
Labels

Comments

@Ao-Last
Copy link

Ao-Last commented Feb 1, 2024

What happened?

Run test from the side panel and it display with green icon while the test cannot even build.

image
@jdneo
Copy link
Member

jdneo commented Feb 2, 2024

Those 'dark' green check marks are the history test status.

You can run the command Test: Clear All Results to reset them.

What's your build error in the output channel?

@Ao-Last
Copy link
Author

Ao-Last commented Feb 2, 2024

Those 'dark' green check marks are the history test status.

You can run the command Test: Clear All Results to reset them.

What's your build error in the output channel?

Thanks for pointing out the 'dark' icon's meaning. The build error is caused by an undefined symbol. I cannot reproduce it again and I will reopen the issue once I meet it again.

@Ao-Last Ao-Last closed this as completed Feb 2, 2024
@Ao-Last
Copy link
Author

Ao-Last commented Feb 2, 2024

@jdneo To reproduce,

  1. make an build error caused by a wrong usage of assert methods. E.g. assertTrue(String)
image 2. run the test from the sidebar by clicking the triangle button and wait for prompt error message image 3. click "Continue", and the icon would be green check again. image

Build error:
image

Tested with "Test: Clear All Results", the icon does not change (in a untested statu not a error status).

@Ao-Last Ao-Last reopened this Feb 2, 2024
@jdneo
Copy link
Member

jdneo commented Feb 4, 2024

Ok, so the green check in step 3 is a history status.

A better solution might be that display the compilation error in the peek view and mark the test as failed.

@jdneo jdneo added bug and removed need more info labels Feb 4, 2024
@Ao-Last
Copy link
Author

Ao-Last commented Feb 4, 2024

Yep, it shows the history status when meeting a compilation error. I suggest to mark it as a test error instead of test failed to distinguish between wrong test code and wrong source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants