Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DebugClient easier to extend (eg. by making private things protected) #179

Open
DanTup opened this issue May 10, 2018 · 0 comments
Open
Labels
feature-request Request for new features or functionality
Milestone

Comments

@DanTup
Copy link

DanTup commented May 10, 2018

The DebugClient class is excellent for testing DAs, but there are some things missing that are more effort to add than they could be.

For example, the hitBreakpoint method works great for launch requests but can't be used for attach requests (since it does the launch itself). Making our own copy of hitBreakpoint means also copying a lot of the private methods resulting in a lot of duplication.

It'd be great if everything was made protected so we could extend it.

(For the specific example above, maybe hitBreakpoint could also check the launch args and attach if it's an attach request?)

@weinand weinand self-assigned this Jun 8, 2018
@weinand weinand added the feature-request Request for new features or functionality label Jun 8, 2018
@weinand weinand added this to the On Deck milestone Jun 8, 2018
@weinand weinand removed their assignment Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants