Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pybind11] Don't install Python #42323

Closed
nickanthony-dgl opened this issue Nov 22, 2024 · 3 comments
Closed

[pybind11] Don't install Python #42323

nickanthony-dgl opened this issue Nov 22, 2024 · 3 comments
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@nickanthony-dgl
Copy link

Is your feature request related to a problem? Please describe.

The vcpkg package for pybind11 lists python3 as a dependency. Having the vcpkg python3 package installed causes some problems if you want to instead use a non-vcpkg Python installation. #42322

Proposed solution

The pybind11 vcpkg package shouldn't make any assumptions about how Python will be installed, so I don't think "python3" should be listed as a dependency in the vcpkg.json file.

Describe alternatives you've considered

No response

Additional context

No response

@nickanthony-dgl nickanthony-dgl added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 22, 2024
@Osyotr
Copy link
Contributor

Osyotr commented Nov 23, 2024

Nothing has changed since the last attempt to decouple pybind11 and python3.
#40784

@nickanthony-dgl
Copy link
Author

Thanks. I had searched for related issues before but for some reason didn't find that one. I don't really understand why an empty overlay port is better than just making the python3 optional, but I will go ahead and try that approach.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 24, 2024

The dependency enforces a defined installation order between python3 and pybind.
The overlay port is to choose a different python3 implementation than the one provided by vcpkg.
Both things together help to ensure a reproducable result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

No branches or pull requests

3 participants