Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ANDROID_ID violates google families policy #2575

Closed
biomancer opened this issue Aug 25, 2023 · 6 comments
Closed

Using ANDROID_ID violates google families policy #2575

biomancer opened this issue Aug 25, 2023 · 6 comments

Comments

@biomancer
Copy link

biomancer commented Aug 25, 2023

Hi!
Our app's audience includes kids and the app cannot send any unique identifiers according to Google Play Families Policy.

react-native-code-push on the other hand uses ANDROID_ID in it's code

mClientUniqueId = Settings.Secure.getString(reactContext.getContentResolver(), Settings.Secure.ANDROID_ID);
and that triggers Google's static code analysis warning looking like that:

SPLIT_BUNDLE [VERSION_CODE]: Policy Declaration - Data Safety Section: Device Or Other IDs Data Type - Device Or Other IDs (some common examples may include Advertising ID, Android ID, IMEI, BSSID, MAC address)

which leads to automatic build rejection.

Why is ANDROID_ID used? Is it possible to replace with something else or make it optional?
What would happen if we replace it with static string like "no-android-id" via patch-package — would it break any functionality?

Environment

  • react-native-code-push version: ours is 7.0.4, but that code is still the same in master, it will trigger the same warning.
  • react-native version: 0.68.5
  • iOS/Android/Windows version: N/A
  • Does this reproduce on a debug build or release build? Release build
  • Does this reproduce on a simulator, or only on a physical device? N/A

Related issues are #2327 and #2297, but they are closed while the issue is still active.

@saoudnazir
Copy link

Same Issue.

@MikhailSuendukov
Copy link
Contributor

We have implemented a fix and it will be available in the next SDK release. Therefore, I am closing this issue, but if you have any questions, you can freely re-open this issue.

@nguyenduythuc
Copy link

image

At react-native-code-push: 8.1.0. I am being rejected by Play Store about "Policy Declaration - Data Safety Section". I never met this issue before. Pls, help! :(

@nguyenduythuc
Copy link

nguyenduythuc commented Dec 18, 2023

@MikhailSuendukov @lucen-ms did you release this pull request #2592 on npm?

@AnatolyPristensky
Copy link
Contributor

@nguyenduythuc, these changes are available in 8.1.1 version. It has been released today: https://www.npmjs.com/package/react-native-code-push

@nguyenduythuc
Copy link

@nguyenduythuc, these changes are available in 8.1.1 version. It has been released today: https://www.npmjs.com/package/react-native-code-push

This is so meaningful to us, thanks for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants