From 0d6af1dbda71c82cfe9dac48cfa45c29e84ba95b Mon Sep 17 00:00:00 2001
From: Binyang Li <binyli@microsoft.com>
Date: Tue, 3 Dec 2024 18:55:21 +0000
Subject: [PATCH] address comments

---
 apps/nccl/src/nccl.cu                      | 1 -
 test/execution-files/allreduce.json        | 2 +-
 test/execution-files/allreduce_nvls.json   | 2 +-
 test/execution-files/allreduce_packet.json | 2 +-
 test/execution-files/sendrecv.json         | 2 +-
 test/execution-files/sendrecv_packet.json  | 2 +-
 6 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/apps/nccl/src/nccl.cu b/apps/nccl/src/nccl.cu
index 9093f9868..cd75edfea 100644
--- a/apps/nccl/src/nccl.cu
+++ b/apps/nccl/src/nccl.cu
@@ -406,7 +406,6 @@ NCCL_API ncclResult_t ncclCommInitRank(ncclComm_t* comm, int nranks, ncclUniqueI
     }
     for (const auto& entry : std::filesystem::directory_iterator(collectiveDir)) {
       if (entry.is_regular_file()) {
-        std::string filename = entry.path().filename().string();
         auto plan = loadExecutionPlan(entry.path());
         commPtr->executionPlans[plan.first].push_back(plan.second);
       }
diff --git a/test/execution-files/allreduce.json b/test/execution-files/allreduce.json
index afc921f4b..0a0a76590 100644
--- a/test/execution-files/allreduce.json
+++ b/test/execution-files/allreduce.json
@@ -1,6 +1,6 @@
 {
   "name": "allreduce_pairs",
-  "colletive": "allreduce",
+  "collective": "allreduce",
   "protocol": "Simple",
   "inplace": true,
   "num_threads_per_block": 512,
diff --git a/test/execution-files/allreduce_nvls.json b/test/execution-files/allreduce_nvls.json
index 069b5df9d..e882d0285 100644
--- a/test/execution-files/allreduce_nvls.json
+++ b/test/execution-files/allreduce_nvls.json
@@ -1,6 +1,6 @@
 {
   "name": "allreduce_nvls",
-  "colletive": "allreduce",
+  "collective": "allreduce",
   "protocol": "Simple",
   "inplace": true,
   "gpus": [
diff --git a/test/execution-files/allreduce_packet.json b/test/execution-files/allreduce_packet.json
index d35a4e96b..545523447 100644
--- a/test/execution-files/allreduce_packet.json
+++ b/test/execution-files/allreduce_packet.json
@@ -1,6 +1,6 @@
 {
   "name": "allreduce_pairs",
-  "colletive": "allreduce",
+  "collective": "allreduce",
   "protocol": "LL",
   "inplace": true,
   "num_threads_per_block": 768,
diff --git a/test/execution-files/sendrecv.json b/test/execution-files/sendrecv.json
index e84a06f7d..439d5f4f4 100644
--- a/test/execution-files/sendrecv.json
+++ b/test/execution-files/sendrecv.json
@@ -1,6 +1,6 @@
 {
     "name": "send_recv",
-    "colletive": "sendrecv",
+    "collective": "sendrecv",
     "protocol": "Simple",
     "inplace": false,
     "gpus": [
diff --git a/test/execution-files/sendrecv_packet.json b/test/execution-files/sendrecv_packet.json
index 3156b6191..5d63ad7c0 100644
--- a/test/execution-files/sendrecv_packet.json
+++ b/test/execution-files/sendrecv_packet.json
@@ -1,6 +1,6 @@
 {
   "name": "send_recv",
-  "colletive": "sendrecv",
+  "collective": "sendrecv",
   "protocol": "LL",
   "inplace": false,
   "gpus": [