address comments

microsoft · Dec 3, 2024 · 0d6af1d · 0d6af1d
1 parent 29b799d
commit 0d6af1d
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 6 deletions.
diff --git a/apps/nccl/src/nccl.cu b/apps/nccl/src/nccl.cu
@@ -406,7 +406,6 @@ NCCL_API ncclResult_t ncclCommInitRank(ncclComm_t* comm, int nranks, ncclUniqueI
     }
     for (const auto& entry : std::filesystem::directory_iterator(collectiveDir)) {
       if (entry.is_regular_file()) {
-        std::string filename = entry.path().filename().string();
         auto plan = loadExecutionPlan(entry.path());
         commPtr->executionPlans[plan.first].push_back(plan.second);
       }

diff --git a/test/execution-files/allreduce.json b/test/execution-files/allreduce.json
@@ -1,6 +1,6 @@
 {
   "name": "allreduce_pairs",
-  "colletive": "allreduce",
+  "collective": "allreduce",
   "protocol": "Simple",
   "inplace": true,
   "num_threads_per_block": 512,

diff --git a/test/execution-files/allreduce_nvls.json b/test/execution-files/allreduce_nvls.json
@@ -1,6 +1,6 @@
 {
   "name": "allreduce_nvls",
-  "colletive": "allreduce",
+  "collective": "allreduce",
   "protocol": "Simple",
   "inplace": true,
   "gpus": [

diff --git a/test/execution-files/allreduce_packet.json b/test/execution-files/allreduce_packet.json
@@ -1,6 +1,6 @@
 {
   "name": "allreduce_pairs",
-  "colletive": "allreduce",
+  "collective": "allreduce",
   "protocol": "LL",
   "inplace": true,
   "num_threads_per_block": 768,

diff --git a/test/execution-files/sendrecv.json b/test/execution-files/sendrecv.json
@@ -1,6 +1,6 @@
 {
     "name": "send_recv",
-    "colletive": "sendrecv",
+    "collective": "sendrecv",
     "protocol": "Simple",
     "inplace": false,
     "gpus": [

diff --git a/test/execution-files/sendrecv_packet.json b/test/execution-files/sendrecv_packet.json
@@ -1,6 +1,6 @@
 {
   "name": "send_recv",
-  "colletive": "sendrecv",
+  "collective": "sendrecv",
   "protocol": "LL",
   "inplace": false,
   "gpus": [