Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INF-0004] Validator should fill hash with PREVIEW pattern for pre-release DXIL version #293

Open
tex3d opened this issue Aug 1, 2024 · 2 comments
Assignees
Labels
active proposal Issues relating to active proposals
Milestone

Comments

@tex3d
Copy link
Collaborator

tex3d commented Aug 1, 2024

Which proposal does this relate to?
proposals/infra/INF-0004-validator-hashing.md

Describe the issue or outstanding question.
The spec does not address pre-release DXIL version behavior. We need to keep track of the last released stable DXIL version and only hash the container if the current DXIL version is less than or equal to this version. We should set the hash to the PREVIEW pattern otherwise.

Additional context
Previously, we would avoid hashing pre-release DXIL by only releasing the external hashing validator once we had a final release for that DXIL version. Now that hashing is included in every intermediate version of the compiler built from the open source project, we need another mechanism to differentiate the release hash behavior from in-development preview features.

@tex3d tex3d added active proposal Issues relating to active proposals needs-triage labels Aug 1, 2024
@microsoft microsoft deleted a comment from Chshyhin Aug 2, 2024
@llvm-beanz
Copy link
Collaborator

For pre-release shader models DXC should run the validator, but it should not
apply the hash. Instead it should apply the PREVIEW sentinel value from the
table above. This allows us to differentiate between shaders validated by a
"final" validator.

Source

Can you be more clear about how you think this should be modified? I believe this covers the intent although perhaps the wording could be more clear.

@damyanp damyanp changed the title Validator should fill hash with PREVIEW pattern for pre-release DXIL version [INF-0004] Validator should fill hash with PREVIEW pattern for pre-release DXIL version Aug 8, 2024
@damyanp damyanp moved this to MSFT Triaging in HLSL Triage Aug 8, 2024
@damyanp damyanp moved this from MSFT Triaging to Triaged in HLSL Triage Aug 8, 2024
@damyanp damyanp added this to the Dormant milestone Aug 8, 2024
@damyanp
Copy link
Member

damyanp commented Aug 8, 2024

@tex3d - can you mark this for triage again once you've had a chance to address Chris's comment above please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
active proposal Issues relating to active proposals
Projects
Status: No status
Status: Triaged
Development

No branches or pull requests

3 participants