You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the issue or outstanding question.
The spec does not address pre-release DXIL version behavior. We need to keep track of the last released stable DXIL version and only hash the container if the current DXIL version is less than or equal to this version. We should set the hash to the PREVIEW pattern otherwise.
Additional context
Previously, we would avoid hashing pre-release DXIL by only releasing the external hashing validator once we had a final release for that DXIL version. Now that hashing is included in every intermediate version of the compiler built from the open source project, we need another mechanism to differentiate the release hash behavior from in-development preview features.
The text was updated successfully, but these errors were encountered:
For pre-release shader models DXC should run the validator, but it should not
apply the hash. Instead it should apply the PREVIEW sentinel value from the
table above. This allows us to differentiate between shaders validated by a
"final" validator.
Can you be more clear about how you think this should be modified? I believe this covers the intent although perhaps the wording could be more clear.
damyanp
changed the title
Validator should fill hash with PREVIEW pattern for pre-release DXIL version
[INF-0004] Validator should fill hash with PREVIEW pattern for pre-release DXIL version
Aug 8, 2024
Which proposal does this relate to?
proposals/infra/INF-0004-validator-hashing.md
Describe the issue or outstanding question.
The spec does not address pre-release DXIL version behavior. We need to keep track of the last released stable DXIL version and only hash the container if the current DXIL version is less than or equal to this version. We should set the hash to the PREVIEW pattern otherwise.
Additional context
Previously, we would avoid hashing pre-release DXIL by only releasing the external hashing validator once we had a final release for that DXIL version. Now that hashing is included in every intermediate version of the compiler built from the open source project, we need another mechanism to differentiate the release hash behavior from in-development preview features.
The text was updated successfully, but these errors were encountered: