Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App consuming Hermes is missing destructors #19

Open
asklar opened this issue Oct 7, 2020 · 4 comments
Open

App consuming Hermes is missing destructors #19

asklar opened this issue Oct 7, 2020 · 4 comments
Assignees
@mganandraj
Labels
bug Something isn't working
Milestone
2021 Q2

Comments

@asklar
Copy link
Member

asklar commented Oct 7, 2020

When building a uwp app against hermes-windows I am finding that a bunch of functionality that is defined in jsi.cpp is missing from the dll. Namely, destructors for a lot of the types are missing, and all of the implementation for HostObject too.
@ghost ghost added the Needs: triage 🔍 label Oct 7, 2020
@Khalef1 Khalef1 added bug Something isn't working and removed Needs: triage 🔍 labels Apr 15, 2021
@Khalef1 Khalef1 added this to the 2021 Q2 milestone Apr 15, 2021
@Khalef1
Copy link

Khalef1 commented Apr 15, 2021

@mganandraj - can you follow up with @asklar here to understand the scenario and what we need to provide?

hansenyy pushed a commit to hansenyy/hermes-windows that referenced this issue Jul 19, 2022
@dreiss @facebook-github-bot
Support getMethod without ::javaobject or local_ref in return (micros…
73c7da6 
…oft#19)

Summary:
Treat `getMethod<JFoo()>` as equivalent to `getMethod<JniType<JFoo>()>`,
which is equivalent to `getMethod<JFoo::javaobject()>`.

Update all call sites.  Some were calling getMethod<local_ref<JFoo>>,
which is equivalent.

Pull Request resolved: facebookincubator/fbjni#19

Test Plan: CI

Reviewed By: cjhopman

Differential Revision: D18121237

Pulled By: dreiss

fbshipit-source-id: 2f0b6fc1909599256cdc708e721c9d877492d54d
@mganandraj
Copy link

Hi @asklar Trying to cleanup the old issues in hermes-windows repo. Do you still need this looked into ? Thanks!

@asklar
Copy link
Member Author

asklar commented Sep 18, 2022

I haven't tried this recently. I think it would be useful to have some basic sanity test in the form of an app that only starts up a hermes engine and runs some JS (all separate from RNW).

@mganandraj
Copy link

I haven't tried this recently. I think it would be useful to have some basic sanity test in the form of an app that only starts up a hermes engine and runs some JS (all separate from RNW).

Agreed. We had such an app long time back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mganandraj mganandraj

Labels
bug Something isn't working
Projects
None yet
Milestone
2021 Q2
Development

No branches or pull requests
3 participants
@mganandraj @asklar @Khalef1