Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Ubuntu from 18.04 to 22.04 #1198

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Bump Ubuntu from 18.04 to 22.04 #1198

merged 2 commits into from
Apr 16, 2024

Conversation

qmuntal
Copy link
Member

@qmuntal qmuntal commented Apr 8, 2024

We are currently using Ubuntu 18.04 to run CI tests. This image is outdated and doesn't support Node 20, which makes AzDO angry: https://dev.azure.com/dnceng-public/public/_build/results?buildId=634776&view=results.

This PR bumps Ubuntu to 22.04.

@qmuntal qmuntal requested review from dagood and gdams April 8, 2024 14:05
@qmuntal qmuntal requested a review from a team as a code owner April 8, 2024 14:05
@qmuntal
Copy link
Member Author

qmuntal commented Apr 9, 2024

Submitted golang-fips/openssl#142 to fix the failing test.

@qmuntal
Copy link
Member Author

qmuntal commented Apr 11, 2024

Submitted golang-fips/openssl#142 to fix the failing test.

The consensus is that OpenSSL is already doing the right (aka secure) thing, so I'll skip TestOverlongMessagePKCS1v15 instead.

@qmuntal qmuntal merged commit f8abe0f into microsoft/main Apr 16, 2024
23 checks passed
@qmuntal qmuntal deleted the dev/qmuntal/node branch April 16, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants