Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for W3C design token format to Adaptive UI #5572

Closed
EisenbergEffect opened this issue Feb 9, 2022 · 1 comment
Closed
Labels
area:fast-foundation Pertains to fast-foundation closed:obsolete No longer valid community:noteworthy An issue or PR of particular interest to the community or planned for an announcement. feature A new feature status:under-consideration Issue is being reviewed by the team.

Comments

@EisenbergEffect
Copy link
Contributor

EisenbergEffect commented Feb 9, 2022

🙋 Feature Request

Let's consider whether we can create an API that takes a w3C design token JSON file as input and uses that to set the tokens for Adaptive UI.

🤔 Expected Behavior

Some sort of API we can call that enables someone to set tokens based on a JSON doc that matches the specified format. Could it be as simple to use as this?

import designTokens from 'design-tokens.json';
import { provideFASTDesignSystem, tokensFromJSON } from '@microsoft/fast-components';

provideFASTDesignSystem()
  .register(
    tokensFromJSON(designTokens)
  );

😯 Current Behavior

No such API exists.

💁 Possible Solution

Details about the standard can be found here: https://github.com/design-tokens/community-group

It's a pretty straight forward JSON formatted document with token names, types, and values. I'd propose that the API be not put on the design system directly so that it can be tree-shaken for folks that don't need this feature. We can create base capabilities in fast-foundation that are then used to create the mapper function for each design system.

🔦 Context

We like web standards.

@EisenbergEffect EisenbergEffect added feature A new feature status:under-consideration Issue is being reviewed by the team. area:fast-foundation Pertains to fast-foundation area:fast-components community:noteworthy An issue or PR of particular interest to the community or planned for an announcement. labels Feb 9, 2022
@EisenbergEffect EisenbergEffect added this to the FAST Foundation Future milestone May 16, 2022
@EisenbergEffect EisenbergEffect modified the milestones: FAST Foundation Future, FAST Foundation 3.0 Jul 13, 2022
@janechu janechu removed this from the FAST Foundation 3.0 milestone May 28, 2024
@janechu
Copy link
Collaborator

janechu commented May 29, 2024

Unfortunately @microsoft/fast-foundation is being deprecated, refer to #6955. Also Adaptive UI has been moved from FAST #6648

@janechu janechu closed this as completed May 29, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in FAST Architecture Roadmap May 29, 2024
@janechu janechu added the closed:obsolete No longer valid label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:fast-foundation Pertains to fast-foundation closed:obsolete No longer valid community:noteworthy An issue or PR of particular interest to the community or planned for an announcement. feature A new feature status:under-consideration Issue is being reviewed by the team.
Projects
None yet
Development

No branches or pull requests

2 participants