Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming concern: subscriptionkey actually meant authoringkey #811

Open
dawwa opened this issue May 20, 2020 · 1 comment
Open

Naming concern: subscriptionkey actually meant authoringkey #811

dawwa opened this issue May 20, 2020 · 1 comment
Assignees
Labels
backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report.
Milestone

Comments

@dawwa
Copy link

dawwa commented May 20, 2020

Versions

@microsoft/botframework-cli/4.8.0 win32-x64 node-v12.16.3
Windows 10

Describe the bug

There seems many places in the CLI and the doc, the subscriptionkey actually meant authoringkey, and the endpoint is authoring endpoint.
e.g., bf luis:version:list

This feels misleading as I was trying to use the key of Prediction Resource, earlier known as a subscription key in the legacy luis API terms, and probably nowadays still being referred as the key of the Prediction Resource.

I'm not sure if it's too late to revise the naming, but this is a bit concerned. Maybe at least ensure the documentation explicitly call out this to avoid confusion.

@benbrown benbrown added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Issue is created by anyone that is not a collaborator in the repository. labels May 20, 2020
@munozemilio munozemilio added the R10 Release 10 - August 17th, 2020 label May 20, 2020
@munozemilio
Copy link
Member

Hi @dawwa, I agree this might be a little bit confusing. The CLI is a wrapper of the Luis endpoint and the intention was to keep it consistent with those docs. We will asses during this cycle your request and take action accordingly

@munozemilio munozemilio added the customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. label May 20, 2020
@munozemilio munozemilio added this to the R10 milestone Jun 25, 2020
@munozemilio munozemilio removed Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. labels Jul 11, 2020
@compulim compulim added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. and removed Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. labels Jul 13, 2020
@munozemilio munozemilio added backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. and removed R10 Release 10 - August 17th, 2020 labels Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report.
Projects
None yet
Development

No branches or pull requests

4 participants