Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#6861]TeamsSSOTokenExchangeMiddleware.DeduplicatedTokenExchangeIdAsync fails on BlobStorage ETag validation #6867

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: [#6861]TeamsSSOTokenExchangeMiddleware.DeduplicatedTokenExchangeIdAsync fails on BlobStorage ETag validation #6867

wants to merge 2 commits into from

Conversation

JhontSouth
Copy link
Collaborator

Fixes #6861

Description

This PR adds the 412 error capture of the BlobsStorage to be handled by TeamsSSOTokenExchangeMiddleware.

Specific Changes

  • Added catch to capture 412 in WriteAsync method of BlobsStorage.

Testing

The following image shows the error being captured.
image

@JhontSouth JhontSouth requested a review from a team as a code owner November 12, 2024 12:42
@JhontSouth JhontSouth added the Automation: Parity with js The PR needs to be ported to JS label Nov 12, 2024
@ceciliaavila ceciliaavila mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Automation: Parity with js The PR needs to be ported to JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TeamsSSOTokenExchangeMiddleware.DeduplicatedTokenExchangeIdAsync fails on BlobStorage ETag validation
1 participant
@JhontSouth