Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataset to SearchInvokeValue #6693

Open
kuojianlu opened this issue Sep 26, 2023 · 0 comments · May be fixed by #6863
Open

Add dataset to SearchInvokeValue #6693

kuojianlu opened this issue Sep 26, 2023 · 0 comments · May be fixed by #6863
Assignees
Labels
feature-request A request for new functionality or an enhancement to an existing one.

Comments

@kuojianlu
Copy link

Use this query to search for the most popular feature requests.

Is your feature request related to a problem? Please describe.
For Adaptive Card dynamic search (example), dataset will be included in Activity.Value. For example,
image

But dataset is not included in SearchInvokeValue. Is there any reason behind this design?

Describe the solution you'd like
Add dataset to SearchInvokeValue. For example:

namespace Microsoft.Bot.Schema
{
    public class SearchInvokeValue
    {
        [JsonProperty("kind")]
        public string Kind { get; set; }

        [JsonProperty("queryText")]
        public string QueryText { get; set; }

        [JsonProperty("queryOptions")]
        public SearchInvokeOptions QueryOptions { get; set; }

        [JsonProperty("dataset")]
        public string Dataset { get; set; }

        [JsonProperty("context")]
        public object Context { get; set; }
    }
}

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@kuojianlu kuojianlu added feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team. labels Sep 26, 2023
@tracyboehrer tracyboehrer added Automation: Parity with python The PR needs to be ported to Python Automation: Parity with js The PR needs to be ported to JS and removed needs-triage The issue has just been created and it has not been reviewed by the team. Automation: Parity with python The PR needs to be ported to Python Automation: Parity with js The PR needs to be ported to JS labels Nov 17, 2023
@sw-joelmut sw-joelmut linked a pull request Oct 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for new functionality or an enhancement to an existing one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants