Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce excess query from history plugin #36514

Open
lin-ycv opened this issue Dec 22, 2024 · 0 comments
Open

Reduce excess query from history plugin #36514

lin-ycv opened this issue Dec 22, 2024 · 0 comments
Labels
Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams

Comments

@lin-ycv
Copy link

lin-ycv commented Dec 22, 2024

Description of the new feature / enhancement

I don't really know how this would be implemented, but some ideas are:

  1. Delay the history query so it doesn't query on every key stroke.
  2. Option to exclude a plugin from history.
  3. Add some kind of metadata to queries invoked by history so plugins can handle it differently.
  4. Removed show in global result option

Scenario when this would be used?

My plugin, EverythingPowerToys, is having issues dealing with the amount of queries sent by history.
The TLDR is that if history's show in global results is enabled, everytime a user does a search, history generates a bunch of query requests, which leads to a long query time and impacts performance.
Full details here:
lin-ycv/EverythingPowerToys#149 (comment)

Supporting information

Was going to file this as a bug, but it's technically working as intended.
This is an edge case, but I would imaging the same thing happens with the windows search plugin?
And if there's some kind of plugin that's paid to run (AI API?), this situation would generate unneeded runs.

@lin-ycv lin-ycv added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams
Projects
None yet
Development

No branches or pull requests

1 participant