Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODIS Fire products don't have platform label since day 2024065 #380

Open
purkristin opened this issue Oct 14, 2024 · 5 comments
Open

MODIS Fire products don't have platform label since day 2024065 #380

purkristin opened this issue Oct 14, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@purkristin
Copy link

I'm querying products of MOD14A2 using platform in the query arguments.
If I am filtering for "platform" = "terra" or "aqua" the latest item in 2024 is from day 065.

However if I don't filter for platform I do get the REAL latest item from the MODIS catalog.
/ at the time of writing this day 273

Example:

aoi = {
    "type": "Polygon",
    "coordinates": [
        [
            [21.56286942832358, 37.26398797975459],
            [25.65109227779675, 37.26398797975459],
            [25.65109227779675, 39.08464307335058],
            [21.56286942832358, 39.08464307335058],
            [21.56286942832358, 37.26398797975459],
        ]
    ],
}

search = catalog.search(
    collections="modis-14A2-061",
    intersects=aoi,
    datetime=f"2024-01-01/2024-12-31",
    query={"platform": {"eq": "aqua"}},
)

items = search.item_collection()

will produce 20 results

while the same search without the platform filter

search = catalog.search(
    collections="modis-14A2-061",
    intersects=aoi,
    datetime=f"2024-01-01/2024-12-31",
)

items = search.item_collection()

will produce 106 results (obviously also including terra at this point).

with the platform argument of the newer items being labeled as empty string.

latest_item = items[0]
latest_item.properties["platform"]
>>> ''
@777arc 777arc self-assigned this Oct 14, 2024
@777arc 777arc added the bug Something isn't working label Oct 14, 2024
@777arc
Copy link
Contributor

777arc commented Oct 21, 2024

Looks like the XML from NASA stopped containing the Platform field, as of March 13 2024. Their XML used to contain:

  <Platforms>
    <Platform>
      <ShortName>Terra</ShortName>
      <Instruments>
        <Instrument>
          <ShortName>MODIS</ShortName>
        </Instrument>
      </Instruments>
    </Platform>
  </Platforms>

but for some reason they took it out. They also seemed to have removed TileID and they didn't add anything...

@777arc
Copy link
Contributor

777arc commented Oct 21, 2024

@purkristin if this is a serious problem for you then go ahead and open the issue in https://github.com/stactools-packages/modis so multiple groups can track it together. Thanks!

@777arc 777arc closed this as completed Oct 21, 2024
@purkristin
Copy link
Author

Sure. But even without the metadata it is easy to tell if it's a terra or aqua product on the Modis side because terra is distributed as MOD and aqua as MYD.
But in planetary computer both are distributed as MODxxx. so it would be nice if you could indicate in the platform label what the initial product was.

@777arc 777arc reopened this Oct 21, 2024
@777arc
Copy link
Contributor

777arc commented Oct 21, 2024

Ah, very good point, I'll get it added to our ingestion pipeline, TBD on when we'll be able to do the backfill

@777arc
Copy link
Contributor

777arc commented Nov 1, 2024

microsoft/planetary-computer-tasks#315 (merge is waiting on a CICD fix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants