Commits on Jan 1, 2024

1. Improve error handling …

   * When a function already returns a `Result`, propagate errors
     instead of panicking with `expect`
   * For `NovaError::SynthesisError`, retain information about the
     original bellpepper error. Since `NovaError` implements `Clone`
     but bellpepper's `SynthesisError` does not, we keep the error
     information as a `String`.
   
   This commit only fixes low-hanging fruit in lib.rs, for functions
   that already return a `Result` and can easily propagate errors just
   by replacing `expect(...)` with `?`. There are still many `unwrap()`
   calls in functions returning `Result` in other modules, particularly
   gadgets. But I don't understand the code well in those parts, and I
   suspect some of those `unwrap()`s actually can't fail based on
   invariants of the code, so it makes perfect sense to leave them as is.

   

   jbearer committed Jan 1, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 9e600d9
   • Browse repository at this point

   Copy the full SHA

   9e600d9 View commit details

   Browse the repository at this point in the history