-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python-package] Infer feature names from pyarrow.Table
#6781
Conversation
xref #6782. This bugfix works only if |
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once CI passes, this looks good to me, thank you for the fix!
pyarrow.Table
pyarrow.Table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I disagree with @borchero though, I don't think this is ready to merge yet. Please see my first round of suggestions.
I didn't find any changelog to update. |
Thanks for being thorough. We don't keep a changelog in source control here. Every pull request is squash merged (1 PR = 1 commit), and the PR titles are used to auto-generate a changelog.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fix, thank you!
I ran these tests on latest master
and confirmed they both fail.
FAILED tests/python_package_test/test_arrow.py::test_arrow_feature_name_auto - TypeError: Wrong type(str) or unknown name(a) in categorical_feature
FAILED tests/python_package_test/test_arrow.py::test_arrow_feature_name_manual - AssertionError: assert ['a', 'b'] == ['c', 'd']
Bugfix for #6780.