Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update etcd API protobuf files #34

Open
jumaffre opened this issue Sep 20, 2022 · 0 comments
Open

Update etcd API protobuf files #34

jumaffre opened this issue Sep 20, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@jumaffre
Copy link
Contributor

The etcd API definition protobuf file (currently https://github.com/microsoft/ccf-kvs/blob/main/proto/etcd.proto) is a stripped down version of https://github.com/etcd-io/etcd/tree/main/api so that we could port a sample app easily to CCF.

However, we should simply include etcd/api under 3rdparty/etcd/api so that it's easily updatable in the future. I've tried doing this but unfortunately this requires extra dependencies (e.g. gogoproto/gogo.proto) and isn't as trivial to setup.

@jumaffre jumaffre added the enhancement New feature or request label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant